Page MenuHomeSchine - Phabricator
Create Task
Maniphest T331

Starmade | Redo/undo doesn't work correctly with Replace
Closed, FinishedPublic
Actions

Description

#1
Trying to use Redo with the replace function will just delete the block.

#2
Confirmed, redo will just make it empty.

I noticed something else too:
the Chunk where the shipcore is in acts weird when using undo.

If you placed a 50x50x50 on the shipcore, replacing it, and then using undo it will result in all blocks being removed but not the ones inside the chunk that surrounds the shipcore.

#3
slightly changed behaviour, only the chunk next to the core gets "redone" the rest stays empty (fills with breaking blocks)

to reproduce:

  • 1 set PLAYER_MAX_BUILD_AREA = 25 in server.cfg
  • 2 place a core in game and set a block of 25x25x25 grey hull next to it
  • 3 use the replace with slot option and change the grey hull to red hull
  • 4 use undo and redo to see the broken effect
  • 5 with 50x50x50 the redo/undo function breaks the mass counter and also the center of mass marker is not recalculated correctly. this is not persistent, on game restart its normal again.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19291 (Dev)
Category
Engine
First occurrence (version)
0.173
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

SmilingDemon updated the task description. (Show Details)Jun 27 2015, 8:23 AM
SmilingDemon added projects: Starmade, Issue Navigation.
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon changed Category from none/unspecified to Engine.
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Single and Multi.
SmilingDemon set First occurrence (version) to 0.173.
SmilingDemon changed Reproducible from uncertain to Yes.
SmilingDemon set Last tested (version) to 0.19291 (Dev).
SmilingDemon edited a custom field.
SmilingDemon edited Serverconfig (server.cfg). (Show Details)
SmilingDemon edited Clientconfig (settings.cfg). (Show Details)
SmilingDemon added a subscriber: SmilingDemon.
SmilingDemon created this task.
SmilingDemon changed the task status from Open to In Queue (Game).
SmilingDemon raised the priority of this task from to Needs Triage/Unclassed.
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJun 27 2015, 8:23 AM
SmilingDemon set Task Type to Bug.Jun 27 2015, 8:23 AM
SmilingDemon set OS-Specific to No.
SmilingDemon set Hardware-Specific to No.
SmilingDemon set Video Card Vendor to uncertain.
SmilingDemon moved this task from Unclassed to Issue affecting current release on the Starmade board.
SmilingDemon triaged this task as Normal priority.
Restricted Application added a commit: Restricted Diffusion Commit.Jul 19 2015, 7:40 AM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 19 2015, 7:40 AM
AndyP claimed this task.Jul 21 2015, 4:26 PM
AndyP moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Jul 21 2015, 4:48 PM
AndyP closed this task as Closed.

Fix confirmed, now properly enqueues the changes,

even allows multiple redo-undo steps.
Takes quite a while for this huge amount of blocks, but as long as you stay connected to the server it stays working on the changes. (Disconnect = abort, is intended behaviour then)

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 21 2015, 4:49 PM
AndyP removed AndyP as the assignee of this task.Aug 4 2015, 7:31 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 11:23 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:32 PM