Page MenuHomeSchine - Phabricator

Starmade | multiplayer to local blueprint save does not work for new power entities
Closed, DuplicatePublic

Description

Trying to save a blueprint from multiplayer to local with a new reactor on your entity, will result in a crash.

[LUA] LOADING: \statistics\ship-index-calculation.lua
SAVED BLUEPRINT SCORE: EntityIndexScore [version=1, weaponDamageIndex=0.0, weaponRangeIndex=0.0, weaponhitPropabilityIndex=0.0, weaponSpecialIndex=0.0, weaponPowerConsumptionPerSecondIndex=0.0, hitpoints=1040.0, armor=100.0, thrust=8.0, shields=110.00000238418579, jumpDriveIndex=0.0, mass=26.299999237060547, powerRecharge=1.0, maxPower=50000.0, support=0.0, docked=false, turret=false, children=[], offensiveIndex=0.0, defensiveIndex=21.833333412806194, powerIndex=50001.0, mobilityIndex=3041.8251832976594, dangerIndex=3063.6585167104654, survivabilityIndex=3063.6585167104654, supportIndex=0.0]
java.lang.NullPointerException
	at org.schema.schine.resource.tag.Tag.<init>(Tag.java:127)
	at org.schema.game.common.controller.elements.power.reactor.tree.ReactorTree.toTagStructure(ReactorTree.java:224)
	at org.schema.game.common.controller.elements.power.reactor.tree.ReactorSet.toTagStructure(ReactorSet.java:124)
	at org.schema.game.common.controller.elements.power.reactor.PowerImplementation.toTagStructure(PowerImplementation.java:734)
	at org.schema.game.common.controller.elements.ManagerContainer.toTagStructure(ManagerContainer.java:1620)
	at org.schema.game.server.data.blueprintnw.BlueprintEntry.writeMeta(BlueprintEntry.java:1413)
	at org.schema.game.server.data.blueprintnw.BlueprintEntry.write(BlueprintEntry.java:1103)
	at org.schema.game.server.controller.BluePrintController.writeBluePrint(BluePrintController.java:1173)
	at org.schema.game.common.data.player.catalog.CatalogManager.writeEntryClient(CatalogManager.java:759)
	at org.schema.game.common.data.player.PlayerState.handleBluePrintQueuesClient(PlayerState.java:4034)
	at org.schema.game.common.data.player.PlayerState.updateLocal(PlayerState.java:1413)
	at org.schema.game.client.controller.GameClientController.updateOthers(GameClientController.java:3176)
	at org.schema.game.client.controller.GameClientController.update(GameClientController.java:1346)
	at org.schema.schine.graphicsengine.core.GLFrame.update(GLFrame.java:842)
	at org.schema.schine.graphicsengine.core.GLFrame.doFrameAndUpdate(GLFrame.java:725)
	at org.schema.schine.graphicsengine.core.GraphicsContext.mainLoop(GraphicsContext.java:828)
	at org.schema.schine.graphicsengine.core.GraphicsContext.startUp(GraphicsContext.java:725)
	at org.schema.game.client.controller.GameMainMenuController.startGraphics(GameMainMenuController.java:1148)
	at org.schema.game.common.Starter.startMainMenu(Starter.java:1457)
	at org.schema.game.common.Starter.main(Starter.java:1001)

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Multiplayer
Reproducible
Yes
Last tested (version)
0.200.153
Category
Control Block System: Systems
First occurrence (version)
0.200.122
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. join the test server
  2. make an entity with new power on it
  3. "save to local"
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Nov 4 2017, 3:34 PM
Restricted Application added a project: CBS: Systems. · View Herald TranscriptNov 4 2017, 3:34 PM
Valck added a subscriber: Valck.Nov 4 2017, 6:52 PM
Ithirahad added a subscriber: Ithirahad.EditedNov 4 2017, 11:39 PM

https://phab.starma.de/T2664

My ticket needs to be merged in, I guess.

lancake changed Affected Gamemode(s) from Single and Multi to Multiplayer.Nov 6 2017, 12:05 PM
Restricted Application removed a project: Game Development. · View Herald TranscriptNov 6 2017, 12:06 PM