Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1788

Launcher | Memory settings validation
Closed, FinishedPublic
Actions

Description

Add validation to the memory settings window.

Should assert:

  • max memory is within (initial+earlyGen) ... ceiling
  • initial, earlyGen >= Java's 64mb minimum
  • initial > earlyGen (see below)
  • values are numbers

Setting earlyGen equal to or higher than initial memory causes the game to crash with the following message -- which is not displayed to the user through either the launcher's output or its logging:

Error occurred during initialization of VM
Too small initial heap for new size specified

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Launcher
Reproducible
Yes
Last tested (version)
161 935803d
Category
Launcher
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

(Tested on Win7x64)

  1. set initial to 1024mb
  2. set earlyGen to 1024mb
  3. click [launch]
  4. watch apparent crash-to-desktop
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

calani created this task.Aug 6 2016, 3:36 AM
Restricted Application added a subscriber: AndyP. · View Herald TranscriptAug 6 2016, 3:36 AM
calani updated the task description. (Show Details)Aug 6 2016, 3:37 AM
calani edited Steps to reproduce. (Show Details)
calani edited Serverconfig (server.cfg). (Show Details)
calani edited Clientconfig (settings.cfg). (Show Details)
calani added a commit: Restricted Diffusion Commit.Aug 13 2016, 10:03 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptAug 13 2016, 10:03 AM
SmilingDemon added a subscriber: SmilingDemon.Aug 14 2016, 12:54 PM
SmilingDemon changed the task status from Resolved to In Queue (Launcher).

-QA Testing-

not fixed

put both on 1024 and game wasnt starting .. reduced early by one and it came up just fine

Restricted Application edited projects, added Launcher Development; removed Quality Assurance. · View Herald TranscriptAug 14 2016, 12:54 PM
SmilingDemon changed Last tested (version) from v2.0.8 / 02ad35e to 159 1eae39f.Aug 14 2016, 12:55 PM
calani added a commit: Restricted Diffusion Commit.Aug 19 2016, 12:14 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptAug 19 2016, 12:14 AM
SmilingDemon changed Last tested (version) from 159 1eae39f to 161 935803d.Aug 19 2016, 6:19 PM

-QA Testing-
Fixed now on Wint 7and Ubuntu 14.04

calani added a commit: Restricted Diffusion Commit.Nov 12 2016, 5:19 AM
calani added a commit: Restricted Diffusion Commit.Nov 15 2016, 9:51 PM
calani added a commit: Restricted Diffusion Commit.
calani renamed this task from Memory: earlyGen must be smaller than initial to Memory settings validation.Nov 15 2016, 10:39 PM
calani updated the task description. (Show Details)Nov 15 2016, 10:57 PM
calani added a commit: Restricted Diffusion Commit.Nov 16 2016, 8:45 AM
calani added a commit: Restricted Diffusion Commit.Nov 17 2016, 8:51 AM
AndyP closed this task as Closed.Dec 15 2016, 12:44 AM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 15 2016, 12:44 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript