Page MenuHomeSchine - Phabricator

Launcher | Add detection of `%_JAVA_OPTIONS%` settings
Closed, FinishedPublic

Description

The settings contained in the _JAVA_OPTIONS environment variable always overwrite any settings passed to java, very likely causing serious issues for players whose systems have this set.

The launcher should detect this and notify the user, possibly asking if they want it removed.

Details

Commits
Restricted Diffusion Commit
Task Type
Feature
Testing Results
Affected Gamemode(s)
Launcher
Reproducible
Yes
Last tested (version)
159 1eae39f
Category
Launcher
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. set _JAVA_OPTIONS=-Xmx512M
  2. Launch game
  3. Crash.
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

calani created this task.Jul 31 2016, 8:48 PM
Restricted Application added a subscriber: AndyP. · View Herald TranscriptJul 31 2016, 8:48 PM
calani changed Category from none/unspecified to Launcher.Aug 13 2016, 7:34 AM
calani edited Serverconfig (server.cfg). (Show Details)
calani edited Clientconfig (settings.cfg). (Show Details)
calani raised the priority of this task from High to Release Blocker.
calani added a commit: Restricted Diffusion Commit.Aug 13 2016, 10:03 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptAug 13 2016, 10:03 AM

-QA Testing-

Looks fixed to me on Win7 .. no idea how to test on Linux or MAC

SmilingDemon set Last tested (version) to 159 1eae39f .Aug 14 2016, 2:07 PM
SmilingDemon moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.
AndyP closed this task as Closed.Dec 15 2016, 12:44 AM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 15 2016, 12:44 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript