Page MenuHomeSchine - Phabricator

Starmade | Shops on the Trade Network will buy any item
Closed, RejectedPublic

Description

This bug is where a shop on the trade guild network will buy any item at the default price if the price is not set for it. For example, I tested by trying to sell 2 million red dirt to a player's shop, and it worked. The player had not set a price for this item. Suffice it to say, this renders shops highly exploitable, since other players can simply sell all their garbage items to it in order to fleece the credits out.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Category
none/unspecified
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
User/Reporter/Contact
Username on Registry
Benevolent27
Steps to reproduce
  1. Have one player create a shop and put it onto the trade network. Ensure the permissions allow the public to access buy/sell from it. Do not set any buy/sell prices for any items.
  2. Use the trade network to sell any item to it. The trade will succeed, and the shop will pay the default price for the item.
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

AndyP claimed this task.Mar 3 2017, 10:51 AM
AndyP closed this task as Rejected.

Issue has been fixed together with a similar problem on the trade network.
So report *was* valid. But is no longer a problem.

Restricted Application removed a project: Issue Navigation. · View Herald TranscriptMar 3 2017, 11:00 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Mar 3 2017, 11:00 AM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".