Page MenuHomeSchine - Phabricator

Launcher | Memory slider: allow (initial+early) lower-bound
Closed, FinishedPublic

Description

Currently the lower-bound of the memory slider is the next power of two up from (initial+early).
This disallows setting 3gb max memory when initial+early is >2gb.

Expected behavior would be to allow a non-power-of-two lower bound, matching the upper-bound functionality.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Launcher
Reproducible
Yes
Last tested (version)
159 1eae39f
Category
Launcher
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Tester information (Internal use only)

Fixed on Win 7 64 and Ubuntu 14.04

OSX: When initial memory is set to 2048 and early generation is set to 1024, the slider will not slide lower than 4096. However, typing 3072 is allowed, and typing in any lower value sets it to 3072 when the user clicks save. This does not appear to be fixed.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

calani created this task.Jun 29 2016, 4:21 PM
calani updated the task description. (Show Details)Jun 29 2016, 4:49 PM
calani edited Serverconfig (server.cfg). (Show Details)
calani edited Clientconfig (settings.cfg). (Show Details)
calani added a commit: Restricted Diffusion Commit.Jun 30 2016, 2:16 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJun 30 2016, 2:16 AM

-QA Testing-
Fixed on Win 7 64 and Ubuntu 14.04

SmilingDemon set Last tested (version) to 158 fe18f38.Aug 1 2016, 11:30 AM
Valiant70 added a subscriber: Valiant70.EditedAug 2 2016, 12:37 AM

OSX: When initial memory is set to 2048 and early generation is set to 1024, the slider will not slide lower than 4096. However, typing 3072 is allowed, and typing in any lower value sets it to 3072 when the user clicks save. This does not appear to be fixed.

SmilingDemon edited Tester information (Internal use only). (Show Details)Aug 2 2016, 7:59 AM

i thought that was intended behaviour and the slider jumping to 4096 as a power of 2 correct
the memory setting gets update to 3072 automatically without thouching the slider.

will ask back if this was intended.

With initial + early generation >= 2GB, the slider will not slide below the next power of two. Below 2 GB, it will slide down to a value equal to initial + early generation. Whichever behavior is intended, something is inconsistent.

calani changed the task status from Resolved to In Queue (Launcher).Aug 2 2016, 4:25 PM

This is incorrect behavior.
The slider should always snap to the lower bound, the powers of 2 in between, and the upper bound.

Restricted Application edited projects, added Launcher Development; removed Quality Assurance. · View Herald TranscriptAug 2 2016, 4:25 PM

The next build fixes the broken use case of (2048+1024) initial+early not snapping to the 3,072 lower-bound. The math is also easier to read now, and slightly faster.


As i've changed the math, please verify that snapping to the upper-bound still works!
(both capping at the memory ceiling, and snapping up to it)

calani added a commit: Restricted Diffusion Commit.Aug 13 2016, 10:03 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptAug 13 2016, 10:03 AM

-QA Testing-

Looks good to me on Win 7 and Ubuntu - both 64

SmilingDemon changed Last tested (version) from 158 fe18f38 to 159 1eae39f.Aug 14 2016, 1:26 PM
SmilingDemon moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.
AndyP closed this task as Closed.Dec 15 2016, 12:44 AM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 15 2016, 12:44 AM