Page MenuHomeSchine - Phabricator

Starmade | Ship entities with station blocks can be uploaded and used on servers where said station blocks are station-only
Closed, RejectedPublic

Description

I'm working on a server project with some friends and we're attempting to limit shields to stations and planets only. However, when someone uploads a blueprint from SP with shields, the ship will still have shields on board even though they're marked station-only. We'd prefer to not disable uploads and the other option is to change the ID# of shields. However, changing the ID# results in stability issues.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Category
Blockconfig
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Move any station block's entry in the blockconfig (for this example, we will use undeathinators) out of the "Station" section and into the "ship" section.
  2. Place undeathinator on your ship.
  3. Save ship and upload to any server of your choice.
  4. Spawn ship in and enjoy your mobile undeathinator. Can be accomplished with warpgates, factories, and other station-only blocks.
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Comr4de updated the task description. (Show Details)Jan 20 2016, 11:15 PM
Comr4de changed Category from none/unspecified to Blockconfig.
Comr4de edited Serverconfig (server.cfg). (Show Details)
Comr4de edited Clientconfig (settings.cfg). (Show Details)
Comr4de changed Reproducible from uncertain to Yes.
Comr4de edited Steps to reproduce. (Show Details)
Comr4de added a subscriber: Comr4de.
Comr4de created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJan 20 2016, 11:15 PM
SmilingDemon shifted this object from the S1 Public space to the Restricted Space space.Jan 22 2016, 3:51 PM
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "All Users".
SmilingDemon set Task Type to Bug.
SmilingDemon set OS-Specific to No.
SmilingDemon set Hardware-Specific to No.
SmilingDemon set Video Card Vendor to uncertain.
SmilingDemon set Affected Gamemode(s) to Single and Multi.
SmilingDemon triaged this task as Pre-Release Quality Assurance priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptJan 22 2016, 3:51 PM
SmilingDemon shifted this object from the Restricted Space space to the S3 Starmade space.Jan 22 2016, 5:27 PM
SmilingDemon moved this task from New / Unconfirmed to Feedback on the Issue Navigation board.

did a fast test

moved the shop module to a ship, restored the original blockconfig and restartet the game.
the shop was at no point operational.

are you able to supply modified configs for your server setup and telling me what blocks should be blocked from having access and should not be operational where exactly

Comr4de added a comment.EditedJan 22 2016, 10:57 PM

We're trying to restrict shields from ships and make them station only. We've had limited success by changing the ID number of shields to -redacted- and -redacted- respectively but it's definitely a stopgap solution. I'll poke BDLS to poke the configs.

Further update: the issue is not the blocks like shops, factories being operational. The issue is that they're allowed to be placed in the first place, whether it be a BP or a shipyard. On a server where restricting shields to stations is part of the custom config, it seriously interferes with that config without some sort of hacky workarounds.

BDLS added a subscriber: BDLS.EditedFeb 11 2016, 7:03 PM

There is the server.cfg setting:

REMOVE_ENTITIES_WITH_INCONSISTENT_BLOCKS = false //This will remove ships that have blocks that are normally disallowed (e.g. space station blocks on ships)

that helped us get by this issue by changing the value to true. Perhaps it should be true by default? OR perhaps the game just deleting the offending blocks, not the entire entity?

Oh .. i did thought you had that set to true to get that effect in the first place.

i can now close this because it works as intended ?
(aside from deleting not complying ships, which is an intended behaviour)

The setting itself is a little iffy sometimes, but it does eventually work. Go ahead and close it.

SmilingDemon closed this task as Rejected.Feb 12 2016, 9:28 AM
Restricted Application edited projects, added Starmade; removed Issue Navigation. · View Herald TranscriptFeb 12 2016, 9:28 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP moved this task from Unclassed to Archived on the Starmade board.Mar 2 2016, 12:18 AM
Restricted Application added a project: Blockconfig. · View Herald TranscriptMar 10 2017, 6:18 PM