Page MenuHomeSchine - Phabricator
Create Task
Maniphest T642

Starmade | Shipyard unloads designs after restart
Closed, FinishedPublic
Actions

Description

This is kind of related to this one:
T545

The Problem that a design unloads on sector inactivity is fixed. So after leaving the sector for some minutes the ship is still loaded.

But after a restart the ship gets unloaded. At least all ressources spent go back into the shipyard computer.
I did not test what happens if blacks have to be placed in other Storages.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.211
Category
Control Block System: Shipyards
First occurrence (version)
0.19431
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

Tarusol updated the task description. (Show Details)Sep 8 2015, 9:40 PM
Tarusol changed Category from none/unspecified to Engine.
Tarusol changed Affected Gamemode(s) from none/unspecified to Single and Multi.
Tarusol set First occurrence (version) to 0.19431.
Tarusol changed Reproducible from uncertain to Yes.
Tarusol set Last tested (version) to 0.19431.
Tarusol edited Serverconfig (server.cfg). (Show Details)
Tarusol edited Clientconfig (settings.cfg). (Show Details)
Tarusol added a subscriber: Tarusol.
Tarusol created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptSep 8 2015, 9:40 PM
AndyP updated the task description. (Show Details)Sep 10 2015, 12:42 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP set Task Type to Bug.
AndyP changed Reproducible from Yes to uncertain.
AndyP removed Last tested (version).
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP claimed this task.
AndyP triaged this task as High priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptSep 10 2015, 12:42 AM
AndyP moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.Sep 10 2015, 12:43 AM
AndyP removed AndyP as the assignee of this task.

-Validated-

SmilingDemon changed the task status from Open to In Queue (Game).Sep 11 2015, 5:15 PM

-Confirmed-

to reproduce

  1. start a game and load in
    Test Yard 2.zip323 KBDownload
  2. disassemble docked ship to design
  3. set the yard to pull blocks in construction
  4. remove a stack of Hull (as example) from the yard
  5. build the ship until it stops for missing parts and log out of the game
  6. in restart the yard is empty and all blocks are back to the chests

in steps 1-6 make sure the server doesnt save

  1. repeat 1 - 5 but use a force_save before exiting in step 5
  2. on reload the design is still in the yard and can be finished building by adding the removed blocks.
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptSep 11 2015, 5:15 PM
Ithirahad added a subscriber: Ithirahad.EditedSep 11 2015, 8:12 PM

Well, at least blocks aren't lost here. >.>

thereaverofdarkness added a comment.Sep 13 2015, 12:03 PM

When I left my shipyard during construction, the blocks were actually lost. This happened twice. I have described the details in bug report T648.

AndyP changed Category from Engine to Control Block System: Shipyards.Oct 26 2015, 10:27 PM
Joriom added a subscriber: Joriom.Dec 20 2015, 11:58 PM
Joriom added a comment.Dec 21 2015, 12:06 AM
In T642#23070, @Ithirahad wrote:

Well, at least blocks aren't lost here. >.>

Confirmed case of blocks lost with cargo update. Ship was being build while server restarted.
Shipyard had some (not enough for entire ship) cargo areac connected, yet it ended up with only 81,6 mass worth of items refunded after restart.
Connected storages with enough cargo capacity did not receive any blocks.

AndyP raised the priority of this task from High to Release Blocker.Mar 8 2016, 8:29 PM
lancake mentioned this in Unknown Object (Maniphest Task).Apr 26 2016, 10:13 AM
schema added a subscriber: schema.Aug 10 2016, 5:09 PM
schema changed the task status from In Queue (Game) to Resolved.

Maybe got fixed along the way. Can't reproduce anymore:

  • Tried in single player which obviously doesn't produce the bug since leaving the game is pretty much the same as force_save
  • Tried on multiplayer with various delays (waiting for unloading sectors, and also sectors still being there when relogging immediately)
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptAug 10 2016, 5:09 PM
lancake added a subscriber: lancake.Aug 11 2016, 4:43 PM
lancake changed the task status from Resolved to In Queue (Game).
  • designs unloading on server restart
  • construction getting canceled on server restart

Both are still there.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptAug 11 2016, 4:43 PM
schema mentioned this in Unknown Object (Maniphest Task).Aug 11 2016, 10:10 PM
lancake lowered the priority of this task from Release Blocker to High.Aug 26 2016, 9:51 AM
schema changed the task status from In Queue (Game) to Resolved.Sep 9 2016, 10:05 AM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptSep 9 2016, 10:05 AM
lancake closed this task as Closed.Sep 9 2016, 1:14 PM

-QA Testing-

Fix confirmed.

Checked both in SP and MP:

  • Construction isn't canceled and keeps progress from the time it's unloaded.
  • Designs don't unload on sector unload/load or server restart.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptSep 9 2016, 1:14 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Reproducible from uncertain to Yes.Sep 9 2016, 1:15 PM
lancake set Last tested (version) to 0.199.211.
Restricted Application added a project: CBS: Shipyards. · View Herald TranscriptMar 10 2017, 6:26 PM