Page MenuHomeSchine - Phabricator

Starmade | ArrayIndexOutOfBoundsException in storage UI
Closed, FinishedPublic

Description

It happens with older blueprints. It happens if you press the "Change items to auto pull" button of a chest.

Screenshot:

Blueprint of that ship:

[2015-05-08 17:05:04] SECOND INVENTORY SET TO Inventory: (3; (4, 20, 10)){}
[2015-05-08 17:05:10] java.lang.ArrayIndexOutOfBoundsException: 1792
[2015-05-08 17:05:10]     at org.schema.game.common.data.element.ElementKeyMap.getInfo(SourceFile:633)
[2015-05-08 17:05:10]     at obfuscated.zD.<init>(SourceFile:15)
[2015-05-08 17:05:10]     at obfuscated.zE.a(SourceFile:287)
[2015-05-08 17:05:10]     at obfuscated.aqT.a(SourceFile:482)
[2015-05-08 17:05:10]     at obfuscated.aoE.a(SourceFile:53)
[2015-05-08 17:05:10]     at obfuscated.aoE.a(SourceFile:53)
[2015-05-08 17:05:10]     at obfuscated.aqp.a(SourceFile:87)
[2015-05-08 17:05:10]     at obfuscated.apR.a(SourceFile:281)
[2015-05-08 17:05:10]     at obfuscated.apV.a(SourceFile:115)
[2015-05-08 17:05:10]     at obfuscated.lH.a(SourceFile:203)
[2015-05-08 17:05:10]     at obfuscated.lS.a(SourceFile:228)
[2015-05-08 17:05:10]     at obfuscated.gX.d(SourceFile:721)
[2015-05-08 17:05:10]     at obfuscated.gC.b(SourceFile:622)
[2015-05-08 17:05:10]     at obfuscated.gC.a(SourceFile:399)
[2015-05-08 17:05:10]     at obfuscated.anm.e(SourceFile:781)
[2015-05-08 17:05:10]     at obfuscated.anm.a(SourceFile:1183)
[2015-05-08 17:05:10]     at obfuscated.C.h(SourceFile:2302)
[2015-05-08 17:05:10]     at obfuscated.Ji.run(SourceFile:86)
[2015-05-08 17:05:10]     at java.lang.Thread.run(Unknown Source)

Full log:

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19349 (Dev)
Category
Ingame GUI/HUD
First occurrence (version)
0.19221 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 6 2015, 11:31 AM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Ingame GUI/HUD.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19221 (Dev).
lancake set Last tested (version) to 0.19242 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Normal.
lancake changed the task status from Open to In Queue (Game).Jun 6 2015, 8:47 PM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 6 2015, 8:47 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:21 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP set Task Type to Bug.
AndyP set Reproducible to uncertain.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
lancake claimed this task.Sep 21 2015, 10:48 AM
lancake changed Reproducible from uncertain to Yes.Sep 26 2015, 9:47 AM
lancake changed Last tested (version) from 0.19242 (Dev) to 0.19349 (Dev).
schema added a subscriber: schema.Nov 7 2015, 10:43 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptNov 7 2015, 10:43 PM
plusnine added a subscriber: plusnine.EditedNov 8 2015, 5:59 AM

v0.19485 -- i'm finding all storage modules in the current release, be they loaded in from blueprints created in older patches, or indeed saved after being rewired in the current release need to have their storage module's wiring connections undone and subsequently rewired in order for their storage filters to begin actually pulling items from their slave modules (storage and factories both). players on our server are reporting needing to rewire their entire factory systems.

all storage wiring in a given sector also breaks again upon sector unload / reload, meaning players have to rewire your factory system each time you return home or do everything manually.

can test using the following blueprint:
http://starmadedock.net/content/ninewerks-products-token-vending-machine.3629/

load it in and place grey hull in the rear, watch as the neighboring storage module is active, set to pull grey hull, but will not until un-wired and re-wired to the rear chest.

v0.19488 - seems okay on loaded blueprints now. will continue to test and let you know anything i find after i upgrade our server to v0.19488,

In T52#30492, @plusnine wrote:

v0.19485 -- i'm finding all storage modules in the current release, be they loaded in from blueprints created in older patches, or indeed saved after being rewired in the current release need to have their storage module's wiring connections undone and subsequently rewired in order for their storage filters to begin actually pulling items from their slave modules (storage and factories both). players on our server are reporting needing to rewire their entire factory systems.
all storage wiring in a given sector also breaks again upon sector unload / reload, meaning players have to rewire your factory system each time you return home or do everything manually.
can test using the following blueprint:
http://starmadedock.net/content/ninewerks-products-token-vending-machine.3629/
load it in and place grey hull in the rear, watch as the neighboring storage module is active, set to pull grey hull, but will not until un-wired and re-wired to the rear chest.
v0.19488 - seems okay on loaded blueprints now. will continue to test and let you know anything i find after i upgrade our server to v0.19488,

plusnine. I have logged a bug for stoage modules not pulling at http://phab.starma.de/T828

I found it was effecting me on the multiplayer server that I play on as well as in single player..

lancake closed this task as Closed.Nov 14 2015, 12:30 PM

-QA Testing-

That pulling should have been fixed in 0.19488 but it's also unrelated to this task.
This issue is fixed though, tried to change every pull on that ship and it worked fine. Don't have more blueprints to check so I assume this is completely fixed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptNov 14 2015, 12:30 PM
Restricted Application added a project: GUI/HUD. · View Herald TranscriptMar 10 2017, 5:50 PM