Page MenuHomeSchine - Phabricator

Starmade | Unable to kick members out of faction
Closed, FinishedPublic

Description

The kick button for members inside the faction tab is missing and you are unable to kick people from the faction

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19357 (Dev)
Category
Ingame GUI/HUD
First occurrence (version)
0.1932
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
Other

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".Jul 16 2015, 1:48 PM
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP set Task Type to Bug.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP removed AndyP as the assignee of this task.
This comment was removed by SmilingDemon.
This comment was removed by SmilingDemon.
SmilingDemon removed SmilingDemon as the assignee of this task.Jul 16 2015, 2:55 PM

more related to T388 ... maybe now only a non founder with the right to kick may do so?

SmilingDemon changed Last tested (version) from V0.1932 to 0.19323 (Dev).Jul 16 2015, 3:49 PM
SmilingDemon edited a custom field.
SmilingDemon changed Video Card Vendor from NVIDIA to Other.
SmilingDemon removed Video Card Model.
SmilingDemon changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJul 16 2015, 3:49 PM

yeah -- no button
broken somewhere after 0.19315 (Dev) i guess

SmilingDemon added a parent task: Unknown Object (Maniphest Task).Jul 16 2015, 3:54 PM
Restricted Application added a commit: Restricted Diffusion Commit.Jul 18 2015, 6:18 AM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 18 2015, 6:18 AM
micdoodle8 changed the task status from Resolved to Open.
Restricted Application edited projects, added Issue Navigation; removed Quality Assurance. · View Herald TranscriptJul 18 2015, 6:19 AM
Restricted Application added a subscriber: Megacrafter127. · View Herald Transcript
micdoodle8 changed the task status from Open to In Queue (Game).Jul 18 2015, 6:19 AM
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJul 18 2015, 6:19 AM
micdoodle8 changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 18 2015, 6:19 AM
SmilingDemon changed the task status from Resolved to In Queue (Game).Jul 19 2015, 8:25 PM

the Kick button is back but there is a small problem
Kicking isnt working ... everyone is considered founder in this regard

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 19 2015, 8:25 PM
schema added a commit: Restricted Diffusion Commit.Jul 21 2015, 9:50 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 21 2015, 9:50 PM
schema added a subscriber: schema.Jul 21 2015, 9:56 PM

also added confirm dialog

SmilingDemon changed Last tested (version) from 0.19323 (Dev) to 0.19337 (Dev).Jul 23 2015, 7:45 PM
SmilingDemon added a comment.EditedJul 23 2015, 7:49 PM

Kick /Promote /Demote tested with 3 Members in Faction
All did work as i would expect
can find only one flaw

If a Character has Promote/Demote rights he cant modify other members of the same rank or himself (Which is OK!) but the Buttons to do so are still shown in that case (only they do nothing)
I on the other hand can Kick a Member of my own rank

SmilingDemon changed the task status from Resolved to In Queue (Game).Jul 23 2015, 7:50 PM
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 23 2015, 7:50 PM
schema added a commit: Restricted Diffusion Commit.Jul 24 2015, 7:24 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 24 2015, 7:24 PM
SmilingDemon changed the task status from Resolved to In Queue (Game).Jul 26 2015, 8:38 AM

I am still not convinced this works right.

2 Members with the same rank and Kick/invite/promote rights are not able to Demote/Promote each other

  • thats correct and drops a warning about too low of a rank to do so.
  • but you still can Kick someone of the same rank ... why should i by unable to demote them but kicking works?
  • after i did kick the member in that fashion its name stayed in the Members list, but the player was from his side without a faction. reinvite fixed that. And beeing kicked again by the founder did remove him from the list properly than
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 26 2015, 8:38 AM
SmilingDemon changed Last tested (version) from 0.19337 (Dev) to 0.19345 (Dev).Jul 26 2015, 8:45 AM
micdoodle8 added a comment.EditedJul 26 2015, 6:58 PM

I'm not able to kick (or even see the kick button) for players of the same rank. Are you sure you haven't edited the roles to allow that?


Note, this is from micdoodle8c's perspective

of course i gave the 2nd rank in my case that permission ... they should be able to remove players of lower rank
but not those of there own rank (at least that is what i would think it should be)

or am i doing something wrong and my install is broken ?

Restricted Application added a commit: Restricted Diffusion Commit.Jul 27 2015, 4:48 PM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 27 2015, 4:48 PM

I can confirm this, it caused a real crisis in my faction when I had to kick an annoying member and I had to delete the faction then re add everyone back to fix it. I couldn't simply see the kick button, even though I was founder

SmilingDemon changed the task status from Resolved to In Queue (Game).EditedJul 29 2015, 8:00 PM

still can kick members of the the same rank if that rank has kick permission

  • is that intended or not ? i think it is not and because of that i put this back into queue , sorry

(also the kicked character stays in the Factions Memberlist even though he left the faction on his end)

Just realised that there is no option for allowing promote and demote under "edit ranks" to be set.
demote is linked to the edit rank permission ... doesnt make the most sense to me :/

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 29 2015, 8:00 PM
Restricted Application added a commit: Restricted Diffusion Commit.Jul 29 2015, 9:57 PM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 29 2015, 9:57 PM

Another commit went missing somehow, should be fixed in the next dev build.

SmilingDemon changed the task status from Resolved to In Queue (Game).Jul 30 2015, 4:33 PM

i am so sorry :/ not working

pressing "Promote" on someone of the same rank drops now the message "you cannot kick players of the same rank" including yourself

still can kick members of the the same rank if that rank has kick permission
(also the kicked character stays in the Factions Memberlist even though he left the faction on his end)

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 30 2015, 4:33 PM
SmilingDemon changed Last tested (version) from 0.19345 (Dev) to 0.19354 (Dev).Jul 30 2015, 4:39 PM
schema added a commit: Restricted Diffusion Commit.Aug 1 2015, 2:59 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptAug 1 2015, 2:59 PM
lancake added a subscriber: lancake.EditedAug 1 2015, 6:49 PM
lancake changed the task status from Resolved to In Queue (Game).

Still no clue what is supposed to be intended and what is considered broken.

It seems founders/rank 5 are always special. They can't demote each other and they can't kick each other.
For any other member that has these permissions, they can kick themselves and the same ranked members (and lower). The demote button is also there for someone of the same rank, but it does not work, it says you're too low ranked.

Other than that, this happens too:

the kicked character stays in the Factions Memberlist even though he left the faction on his end. This only happens if you kick someone of the same rank as yours.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptAug 1 2015, 6:49 PM
lancake changed First occurrence (version) from V0.1932 to 0.1932.Aug 1 2015, 6:49 PM
lancake changed Last tested (version) from 0.19354 (Dev) to 0.19357 (Dev).
Megacrafter127 shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:53 PM
Megacrafter127 changed the edit policy from "Starmade (Project)" to "All Users".
Megacrafter127 edited Serverconfig (server.cfg). (Show Details)
Megacrafter127 edited Clientconfig (settings.cfg). (Show Details)
Megacrafter127 claimed this task.
Megacrafter127 removed Megacrafter127 as the assignee of this task.

respacing

schema changed the task status from In Queue (Game) to Resolved.Sep 1 2015, 1:31 PM

It was intended that you can't demote or kick members of your own rank. The error message on kick went to the wrong player and he remained in the list (when tried to kick a player with the same rank). That has now been fixed. Also it has been fixed that the buttons will even show up for something you can't do.

Founders can now be kicked, if they are inactive for a amount of time defined in the serverConfig

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptSep 1 2015, 1:31 PM
schema added a commit: Restricted Diffusion Commit.Sep 1 2015, 1:33 PM
SmilingDemon closed this task as Closed.Sep 1 2015, 5:11 PM

-QA Testing-

Fixed ... cant find any other problem with kicking

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptSep 1 2015, 5:11 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP removed SmilingDemon as the assignee of this task.Sep 7 2015, 9:05 PM
Restricted Application added a project: GUI/HUD. · View Herald TranscriptMar 10 2017, 6:30 PM