Page MenuHomeSchine - Phabricator
Create Task
Maniphest T400

Starmade | Warpgate faction permission issue
Resolved, needs quality check / confirm fix, HighPublic
Actions

Description

Warpgates can be linked by non faction members regardless if its factioned or not, I.E

When player 1 factions his warpgate player 2 who is not inside of player 1 faction can unlink or link said factioned warpgate without blowing off the faction module

Steps to reproduce for testers

  1. Make a warpgate
  2. Get player one to faction said warpgate
  3. After its factioned get player 2 to rightclick to mark another warpgate (this one is unfactioned can be factioned but I did not for my test)
  4. Get player 2 to leftclick the warp computer on the factioned warpgate and enter the cords

You will now be able to use it regardless of the fact it was linked by someone who was not inside the faction.

This leads to warpgates on large servers that admins put down to be unlinked and linked to a homebase of a player
or a warpgate of a faction to another factions homebase etc

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
v0.19439
Category
Control Block System: Functional
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain

Related Objects

Event Timeline

Zackey_TNT updated the task description. (Show Details)Jul 12 2015, 1:18 AM
Zackey_TNT added a project: Starmade.
Zackey_TNT shifted this object from the S1 Public space to the Restricted Space space.
Zackey_TNT changed Category from none/unspecified to Control Block System: Functional.
Zackey_TNT changed Affected Gamemode(s) from none/unspecified to Single and Multi.
Zackey_TNT changed Reproducible from uncertain to Yes.
Zackey_TNT set Last tested (version) to v0.1932.
Zackey_TNT changed Video Card Vendor from uncertain to NVIDIA.
Zackey_TNT set Video Card Model to GTX 760.
Zackey_TNT edited Serverconfig (server.cfg). (Show Details)
Zackey_TNT edited Clientconfig (settings.cfg). (Show Details)
Zackey_TNT added a subscriber: Zackey_TNT.
Zackey_TNT created this task.
Zackey_TNT raised the priority of this task from to High.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJul 12 2015, 1:18 AM
Megacrafter127 moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.Jul 12 2015, 1:38 AM
Megacrafter127 added a subscriber: Megacrafter127.
Megacrafter127 claimed this task.
Megacrafter127 removed Megacrafter127 as the assignee of this task.

Validated

Megacrafter127 set Task Type to Bug.Jul 12 2015, 1:50 AM
Megacrafter127 edited a custom field.
Megacrafter127 set OS-Specific to No.
Megacrafter127 set Hardware-Specific to No.
Megacrafter127 edited Serverconfig (server.cfg). (Show Details)
Megacrafter127 edited Clientconfig (settings.cfg). (Show Details)
Megacrafter127 changed the task status from Open to In Queue (Game).

Confirmed.

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJul 12 2015, 1:50 AM
Megacrafter127 removed Megacrafter127 as the assignee of this task.Jul 12 2015, 1:50 AM
AndyP shifted this object from the Restricted Space space to the S1 Public space.Jul 12 2015, 9:03 AM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP claimed this task.
AndyP reassigned this task from AndyP to Megacrafter127.
Restricted Application added a commit: Restricted Diffusion Commit.Jul 17 2015, 4:54 PM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 17 2015, 4:54 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
micdoodle8 added a subscriber: micdoodle8.Jul 17 2015, 4:55 PM
micdoodle8 changed the task status from Resolved to In Queue (Game).
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 17 2015, 4:55 PM
micdoodle8 moved this task from Backlog / Unclassed to micdoodle8 on the Game Development board.Jul 17 2015, 4:55 PM
micdoodle8 changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 17 2015, 4:55 PM
Megacrafter127 changed Last tested (version) from v0.1932 to v0.19361.Aug 5 2015, 6:02 PM
Megacrafter127 added a subscriber: SmilingDemon.
Megacrafter127 closed this task as Closed.

Fix confirmed, when attempting to set the destination, an error message pops up stating 'invalid faction id', and the destination is not set.
Tested with @SmilingDemon on the testserver.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptAug 5 2015, 6:04 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 11:28 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP removed Megacrafter127 as the assignee of this task.Aug 22 2015, 10:07 AM
Chandler added a subscriber: Chandler.Sep 22 2015, 7:34 PM

I have an issue with this "fix", I can no longer connect to allied factions. What was wrong with the way it was...If you don't want you computer to be reprogrammed you protect it with a block, no biggie. now nothing works.... out of all the real bugs out there..... you chose this "complaint" why not fix the permission module which is a real issue. AHHH

spunkie added a subscriber: spunkie.Sep 23 2015, 8:46 PM

Could just hand the marker to the allied faction member.

Chandler added a comment.Sep 23 2015, 9:42 PM

Doesnt work. when a non faction member hold the marker it says unknown, and wont work.

Zackey_TNT added a comment.Sep 24 2015, 4:03 AM
In T400#25074, @Chandler wrote:

I have an issue with this "fix", I can no longer connect to allied factions. What was wrong with the way it was...If you don't want you computer to be reprogrammed you protect it with a block, no biggie. now nothing works.... out of all the real bugs out there..... you chose this "complaint" why not fix the permission module which is a real issue. AHHH

Intended.
Before hand faction permission was completely ignored.
If you want to so bad simply faction it to yourself...

Ally should have no problem with that

lancake renamed this task from Warpgate faction issue to Warpgate faction permission issue.Sep 24 2015, 8:18 AM
lancake reopened this task as Open.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptSep 24 2015, 8:18 AM
lancake added a comment.Sep 24 2015, 8:19 AM

Needs retesting, confirmation that permissions don't work properly between your faction gate and other stations.

Permission module should allow it for any station, if you're not using this it should allow ally <-> faction maybe but that's not really needed if permission modules work fine

Chandler added a comment.Sep 24 2015, 4:23 PM
In T400#25188, @Zackey_TNT wrote:
In T400#25074, @Chandler wrote:

I have an issue with this "fix", I can no longer connect to allied factions. What was wrong with the way it was...If you don't want you computer to be reprogrammed you protect it with a block, no biggie. now nothing works.... out of all the real bugs out there..... you chose this "complaint" why not fix the permission module which is a real issue. AHHH

Intended.
Before hand faction permission was completely ignored.
If you want to so bad simply faction it to yourself...
Ally should have no problem with that

The point is this, i cannot connect my gate to his gate. My station has 5 gates which lead to allies. none now work. I dont thing that my ally wants to make his station mine, sort of the point of having factions..:)

Chandler added a comment.Sep 24 2015, 4:24 PM
In T400#25207, @lancake wrote:

Needs retesting, confirmation that permissions don't work properly between your faction gate and other stations.
Permission module should allow it for any station, if you're not using this it should allow ally <-> faction maybe but that's not really needed if permission modules work fine

Yeap, we tested the Perms block too, didn't work.. thank you for opening and relooking at it..

Megacrafter127 changed the task status from Open to In Queue (Game).EditedSep 27 2015, 8:53 AM

-Confirmed-
The faction permission module does not disable the faction-protection of an adjacent warpgate-computer's destination-setting. Whether or not the player attempting to change them is and admin or not had no visible influence on the behaviour, even if admins were permitted to bypass faction-restrictions in the server.cfg.

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptSep 27 2015, 8:53 AM
Megacrafter127 changed Last tested (version) from v0.19361 to v0.19439.Sep 27 2015, 8:54 AM
Megacrafter127 changed Video Card Vendor from NVIDIA to uncertain.
Megacrafter127 removed Video Card Model.
lancake moved this task from Archived to Issue affecting current release on the Starmade board.Sep 28 2015, 3:09 PM
lancake raised the priority of this task from High to Release Blocker.
lancake lowered the priority of this task from Release Blocker to Urgent.
lancake lowered the priority of this task from Urgent to High.
micdoodle8 changed the task status from In Queue (Game) to Resolved.Oct 2 2015, 12:13 AM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptOct 2 2015, 12:13 AM
Restricted Application added a commit: Restricted Diffusion Commit.Oct 2 2015, 12:52 AM
Restricted Application added a project: CBS: Functional. · View Herald TranscriptMar 10 2017, 6:30 PM
AndyP moved this task from Backlog / Unclassed to Alpha on the CBS: Functional board.Mar 11 2017, 9:11 PM
AndyP moved this task from Alpha to Beta on the CBS: Functional board.