Page MenuHomeSchine - Phabricator

Starmade | EMP effect doesn't drain all power
Closed, FinishedPublic

Description

It doesn't subtract the power if your power damage is bigger than the remaining power of the ship.

Example

  • 50 000 power in ship, gets hit by a 10 000 power reduction resulting in 40 000 power -> works
  • 5 000 power in ship, gets hit by a 10 000 power reduction resulting in no power reduction, the regen does stop for a second. -> doesn't work

If I for example had a EMP weapon that hits 1 million each projectile I could not drain any ship that has less than 1 million power storage.

How to reproduce:

  1. make an emp weapon with roughly a total of 500 blocks
  2. add some power cap to a shipcore
  3. give it power with /power drain -200000
  4. shoot at it and notice that at some point you stop draining since your damage > remaining power

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19316 (Dev)
Category
Control Block System: Weapons
First occurrence (version)
0.15
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 25 2015, 9:02 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Control Block System: Weapons.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.15.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19291 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Normal.
Restricted Application added projects: Issue Navigation, Starmade. · View Herald TranscriptJun 25 2015, 9:02 PM
AndyP added a subscriber: AndyP.
AndyP claimed this task.
AndyP removed AndyP as the assignee of this task.

validated

lancake set Task Type to Bug.Jul 8 2015, 12:01 AM
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJul 8 2015, 12:01 AM
schema added a commit: Restricted Diffusion Commit.Jul 9 2015, 2:53 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 9 2015, 2:53 AM
lancake changed Last tested (version) from 0.19291 (Dev) to 0.19314 (Dev).Jul 9 2015, 7:18 PM
lancake changed the task status from Resolved to In Queue (Game).
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 9 2015, 7:18 PM

The original issue is fixed for all weapons as far as I can see, everything gets drained to 0 eventually. I can't test high damage cannons with T383 still here but works fine for 1 penetration depth weapons.

There is a power display/update issue for both missiles and damage pulse, and maybe beams too but for them it works half of the time:

  • The power drain hit (of an EMP effect in my case) doesn't update the power storage if you used missiles/damage pulse, if you do something like /power_drain 1000 it will drain 1000 and also update the power storage. It's very similar to T6.
schema added a commit: Restricted Diffusion Commit.Jul 10 2015, 1:17 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 10 2015, 1:17 AM
schema added a subscriber: schema.Jul 10 2015, 11:53 AM

should now always update for missiles and pulses

lancake changed Last tested (version) from 0.19314 (Dev) to 0.19316 (Dev).Jul 10 2015, 3:53 PM
lancake closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 10 2015, 3:53 PM
AndyP removed a subscriber: AndyP.Jul 19 2015, 7:45 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 11:23 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
Restricted Application added a project: CBS: Weapons. · View Herald TranscriptMar 10 2017, 6:32 PM