Page MenuHomeSchine - Phabricator

Starmade | Roll keys (Z/X) and roll control not working properly
Closed, FinishedPublic

Description

Attempting to use either the roll controls (default Z and X) or mouse rolling (Holding Crtl and moving the mouse from side to side) to roll your ship results in the ship jerking around a bit while rolling, and eventually the ship flipping around in weird directions.


If you roll left or right with your cursor in the middle, it's fine.

If you roll left or right with your cursor off center, you get weird results. The best I can describe it, is that it also rolls your cursor around the center point...
That's an old issue though, been there for a while but never reported it.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19527 (Dev)
Category
Input/Controls
First occurrence (version)
0.19525 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. put a station or ship down and put a long hull line on it for you to use as "target"
  2. get in a ship, modify its total rotational potential and its mass
  3. point towards one end of the grey line, then to the other and while the ship is changing direction start rolling like your life depends on it.

You should be able to see the issue described in the Tester Information section. Modify the mass of a hull block to make it easier for you to see.

Tester information (Internal use only)

Not fixed and there may also be a new issue with it.

Test example:

  • my ship core/camera is always the center of mass
  • I use a grey hull line as a reference to see if me changing direction follows that line while rolling. I aim towards one end of the grey line, then I aim towards the other end. While I'm changing directions I roll my ship and see if it stays on the line or not.

When Total rotational potential of Z is 10.0 (all your mass is perfectly on the Z-axis):

  • Rolling appears to be fine but even here you can notice a mistake. I changed direction of my ship across the grey line and I rolled while doing that. I noticed that my ship went offset a bit on the grey line and that should in theory not happen.

As soon as the total rotational potential of the Z-axis is lower, it starts becoming more severe and severe. At some point it's bad enough that rolling when not changing direction will cause unwanted direction changing of your ship.


I checked this out with the debug camera and it doesn't really show much new for me besides that the ship does more than just rolling around its own Z-axis, as portrayed in the picture above.


Unfortunately there also seems to be a new issue caused by this fix. Now your ship already slightly rotates by just changing directions. Just point your cursor to the edge of your screen and go left/right, up/down and you'll easily see your ship rotating towards the direction. This issue is always there independent on your Total Rotational Potential

Event Timeline

Ithirahad updated the task description. (Show Details)Dec 15 2015, 7:07 PM
Ithirahad changed Category from none/unspecified to Physics.
Ithirahad changed Affected Gamemode(s) from none/unspecified to Single and Multi.
Ithirahad set First occurrence (version) to Latest dev cycle.
Ithirahad changed Reproducible from uncertain to Yes.
Ithirahad set Last tested (version) to Latest dev build.
Ithirahad edited Serverconfig (server.cfg). (Show Details)
Ithirahad edited Clientconfig (settings.cfg). (Show Details)
Ithirahad added a subscriber: Ithirahad.
Ithirahad created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptDec 15 2015, 7:07 PM
Ithirahad updated the task description. (Show Details)Dec 15 2015, 7:09 PM
Ithirahad set Task Type to Bug.
Ithirahad set OS-Specific to No.
Ithirahad set Hardware-Specific to No.
Ithirahad set Video Card Vendor to uncertain.
Ithirahad renamed this task from Buggy roll behavior to Roll keys (Z/X) and roll control not working (DEV).
Ithirahad renamed this task from Roll keys (Z/X) and roll control not working (DEV) to Roll keys (Z/X) and roll control not working properly (DEV).
lancake claimed this task.

-Validated-

Yeah, seems to happen if your cursor is off-center

lancake shifted this object from the S1 Public space to the S3 Starmade space.Dec 17 2015, 4:06 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed First occurrence (version) from Latest dev cycle to 0.19525 (Dev).
lancake changed Last tested (version) from Latest dev build to 0.19527 (Dev).
lancake triaged this task as Pre-Release Quality Assurance priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptDec 17 2015, 4:06 PM

Hm, I seemed to get the flippy derping whether or not my cursor was centered; I tested it several times after hitting the V key to recenter my cursor.

I can't reproduce the jerking anymore but I still notice an issue we had in the past.

If you roll left or right with your cursor in the middle, it's fine.

If you roll left or right with your cursor off center, you get weird results. The best I can describe it, is that it also rolls your cursor around the center point...
That's an old issue though, been there for a while but never reported it.

lancake updated the task description. (Show Details)Dec 17 2015, 6:29 PM
lancake moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake changed Category from Physics to Engine.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptDec 17 2015, 6:29 PM
lancake renamed this task from Roll keys (Z/X) and roll control not working properly (DEV) to Roll keys (Z/X) and roll control not working properly.Dec 22 2015, 5:24 PM
lancake updated the task description. (Show Details)Jan 1 2016, 9:27 AM

Verified bug.

Please increase the priority because it has become impossible to maneuver ships around docking arms on stations.

Tested various ship sizes and compositions. Only when using a ship with 8 way symmetry in its thruster layout can you achieve normalcy in behavior.

It seems to be dependent on the spacial coordinates of all thuster points in relation to the center of mass of the ship. Asymmetric builds ie more thrusters in the back then in the nose causes the bacon dance. Negligible to an extend on small ships it is impossible to do aileron rolls with large ships. For some reason it also seems to interfere with mouse movement by forcefully moving the mouse cursor outside of the threshold in the center of the screen. The ship will attempt to aim its nose at the cursor thereby moving in what seems like the movement pattern described in the first post. It also issnt restricted by the normal turning potential factor of the ship causing 500+ meter ships to spasm out of control in said directions.

SpaceKing added a subscriber: SpaceKing.EditedApr 1 2016, 12:08 AM

Still happens whether cursor is centered or not.
Makes the game pretty much unplayable.

Also: it's intriguingly much worse in SP.

lancake lowered the priority of this task from Pre-Release Quality Assurance to Urgent.
lancake mentioned this in Unknown Object (Maniphest Task).Apr 26 2016, 10:13 AM

Yes, I can confirm this.

Seems like ever since the Thrust update way back when, ships have been wobbling when rolling. Before that we had silky smooth rolling along the Z axis of the ship that only got slower when the ship size went up. Cores alone would whirl around like in a blender, but larger ships had a nice smooth roll instead of wobbing around and making you feel like you're not in control of the ship.

AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:06 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:06 PM
schema added a commit: Restricted Diffusion Commit.Mar 13 2017, 11:32 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 13 2017, 11:32 PM
schema added a subscriber: schema.Mar 13 2017, 11:33 PM

added config option DEBUG_SHIP_CAM_ON_RCONTROL
this will enable testers to see the debug camera. This is basically the view that the ship is trying to align on.

The bug was that on Roll, the camera was rotating around the forward vector of the ship instead of its own forward vector. this is now fixed.

To test this, make sure that the center of mass is where your view is (e.g. on the core). Else you will have trouble filtering out the movement that is induced by rotating around the center of mass.

lancake changed the task status from Resolved to In Queue.Mar 14 2017, 2:34 PM

-QA Testing-

Not fixed and there may also be a new issue with it.

Test example:

  • my ship core/camera is always the center of mass
  • I use a grey hull line as a reference to see if me changing direction follows that line while rolling. I aim towards one end of the grey line, then I aim towards the other end. While I'm changing directions I roll my ship and see if it stays on the line or not.

When Total rotational potential of Z is 10.0 (all your mass is perfectly on the Z-axis):

  • Rolling appears to be fine but even here you can notice a mistake. I changed direction of my ship across the grey line and I rolled while doing that. I noticed that my ship went offset a bit on the grey line and that should in theory not happen.

As soon as the total rotational potential of the Z-axis is lower, it starts becoming more severe and severe. At some point it's bad enough that rolling when not changing direction will cause unwanted direction changing of your ship.


I checked this out with the debug camera and it doesn't really show much new for me besides that the ship does more than just rolling around its own Z-axis, as portrayed in the picture above.


Unfortunately there also seems to be a new issue caused by this fix. Now your ship already slightly rotates by just changing directions. Just point your cursor to the edge of your screen and go left/right, up/down and you'll easily see your ship rotating towards the direction. This issue is always there independent on your Total Rotational Potential

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptMar 14 2017, 2:34 PM
lancake edited Steps to reproduce. (Show Details)Mar 14 2017, 2:36 PM
lancake edited Tester information (Internal use only). (Show Details)
schema added a commit: Restricted Diffusion Commit.Mar 14 2017, 11:49 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 14 2017, 11:49 PM
schema changed the task status from Resolved to In Queue.Mar 14 2017, 11:49 PM

wrong commit message

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptMar 14 2017, 11:49 PM
AndyP changed Category from Engine to Input/Controls.Mar 15 2017, 6:43 PM
AndyP edited Serverconfig (server.cfg). (Show Details)
AndyP edited Clientconfig (settings.cfg). (Show Details)
Restricted Application edited projects, added Controls; removed Engine. · View Herald TranscriptMar 15 2017, 6:43 PM
AndyP moved this task from Backlog / Unclassed to Alpha on the Controls board.Mar 16 2017, 7:44 PM
AndyP edited projects, added Game Development (Alpha); removed Game Development.

Be finally gone, filthy bug

schema added a commit: Restricted Diffusion Commit.Mar 17 2017, 4:01 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application added a project: Quality Assurance. · View Herald TranscriptMar 17 2017, 4:01 PM

fix should be in 0.199.485

AndyP awarded a token.Mar 17 2017, 5:46 PM

Needs some more testing but the severe issues are gone. It's still possible from time to time where it seems to register a 180° flip but not sure yet how to reproduce that consistently.

lancake closed this task as Closed.Jun 16 2017, 8:12 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 16 2017, 8:12 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript