Page MenuHomeSchine - Phabricator

Starmade | Replace filter for not the same type of blocks ignore set orientation
Closed, FinishedPublic

Description

If you replace a block with a slab it seems to ignore orientation all together.

Steps to reproduce:

  1. Place down any type of block.
  2. Get a slab and set the orientation to something other then the default.
  3. Set the replace fitler to replace the type of block you set down.
  4. Replace the block from step one with a slab and notice the orientation is ignored.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.198.128
Category
Engine
First occurrence (version)
0.19491 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. replace cubic blocks with other block types
  2. change selected orientation in build mode and see if that corresponds with what is actually replaced with

Should be fine for tetra and hepta blocks
Corners and wedges are usually incorrect (see tester information)

Tester information (Internal use only)

Works fine for all block types.

However, replacing cargo space with any block will still force that block into the default orientation and not use the one you have selected in advanced build mode.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Zackey_TNT updated the task description. (Show Details)Nov 20 2015, 12:05 AM
Zackey_TNT edited Serverconfig (server.cfg). (Show Details)
Zackey_TNT edited Clientconfig (settings.cfg). (Show Details)
Zackey_TNT added a subscriber: Zackey_TNT.
Zackey_TNT created this task.
Zackey_TNT raised the priority of this task from to Needs Triage/Unclassed.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptNov 20 2015, 12:05 AM
Zackey_TNT set Task Type to Bug.Nov 20 2015, 12:07 AM
Zackey_TNT set Category to none/unspecified.
Zackey_TNT set Affected Gamemode(s) to none/unspecified.
Zackey_TNT set First occurrence (version) to 0.19491(dev build).
Zackey_TNT set Reproducible to uncertain.
Zackey_TNT set Last tested (version) to 0.19491(dev build).
Zackey_TNT set OS-Specific to No.
Zackey_TNT set Hardware-Specific to No.
Zackey_TNT set Video Card Vendor to uncertain.
lancake claimed this task.Nov 20 2015, 1:40 PM
lancake shifted this object from the S1 Public space to the S3 Starmade space.Nov 20 2015, 1:44 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed First occurrence (version) from 0.19491(dev build) to 0.19491 (Dev).
lancake changed Reproducible from uncertain to Yes.
lancake changed Last tested (version) from 0.19491(dev build) to 0.19492 (Dev).
lancake renamed this task from Replace filter for slabs ignore orientation to Replace filter for cubic blocks/slabs ignore orientation .
lancake triaged this task as High priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptNov 20 2015, 1:44 PM
lancake added a comment.EditedNov 20 2015, 1:56 PM

-Confirmed-

This is something that happens for most blocks, mostly because it's something that's not implemented.

What works:

  • If you replace a wedge with another wedge, it preserves the rotation of the original block which is fine.
  • If you replace a cubic block with another cubic block, it doesn't matter (so that's fine).
  • Replacing slabs with slabs is fine though (even with different sizes), it uses the orientation of the original block.

What doesn't work:

  • If you replace a cubic block with a wedge/corner/slabs/any non cubic block OR replace a block with something that's not the same type (corner with wedge, tetra with slab, ...), it uses the default orientation and this is not OK. In this case it should replace the block with the rotation set in your advanced build mode. This is not something new but it's more obvious now that we have slabs.
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake renamed this task from Replace filter for cubic blocks/slabs ignore orientation to Replace filter for not the same type of blocks ignore set orientation.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptNov 20 2015, 1:58 PM

This also (and has for a while) occurs with corners, using remove/replace with corners usually requires going back and fixing them.

Its also been happening with heptas,recently, simply changing from one hepta to another (hull to standard or one color to another) will place the new block in default orientation.

schema added a commit: Restricted Diffusion Commit.Apr 15 2016, 1:07 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 15 2016, 1:07 AM
lancake changed the task status from Resolved to In Queue (Game).Apr 16 2016, 2:49 PM

-QA Testing-

Partially fixed:
Depending on block type you want to replace with, you'll get correct or incorrect orientations.
These tests were all done by replacing blue cubic hull with different orientation blocks (hepta, tetra, ...). It shows the same behaviour for other similar tests.

What works:

  • Replacing a different block type with one that has 8 orientations: tetra and hepta works fine, the orientation you've selected in build mode is the one that's replaced.

What doesn't work:

  • Multiple different results
    • Replacing a different block type with one that has 12 orientations: wedge causes the replaced orientation to be off by 4 orientations. The orientation you've selected is not the one that appears after replacing the block.
    • Replacing a different block type with one that has 24 orientations: corner has 16 of the 24 orientations off by 8 orientations, the remaining 8 get replaced fine.

Image that might clarify a bit:

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptApr 16 2016, 2:49 PM
lancake changed Last tested (version) from 0.19492 (Dev) to 0.197.39.Apr 16 2016, 2:50 PM
lancake edited Steps to reproduce. (Show Details)
lancake edited Tester information (Internal use only). (Show Details)
schema added a commit: Restricted Diffusion Commit.Apr 17 2016, 8:28 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 17 2016, 8:28 PM
lancake changed the task status from Resolved to In Queue (Game).Apr 18 2016, 7:18 PM

-QA Testing-

Works fine for all block types.

However, replacing cargo space with any block will still force that block into the default orientation and not use the one you have selected in advanced build mode.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptApr 18 2016, 7:18 PM
lancake changed Last tested (version) from 0.197.39 to 0.197.41.Apr 18 2016, 7:18 PM
lancake edited Tester information (Internal use only). (Show Details)
lancake changed the task status from In Queue (Game) to Resolved.Apr 25 2016, 12:29 PM

Appears fixed now.

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 25 2016, 12:29 PM
lancake closed this task as Closed.May 21 2016, 10:31 PM

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptMay 21 2016, 10:31 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.197.41 to 0.198.128.May 21 2016, 10:31 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:22 PM