Page MenuHomeSchine - Phabricator

Starmade | Ship always inherits faction after reloading sector
Closed, FinishedPublic

Description

Background info:

Docking unfactioned ships to a factioned base, and that dock has no permission module will put the faction signature of that base on the unfactioned ship. When the ship is undocked, it is again neutral.
Docking factioned ships to a factioned base is only possible if there is a permission module on it. This allows any other faction to dock and it should remain unchanged.

Now...I did notice an exploit with this and I assume that happened with you: Docking to a rail with permission module next to it should not touch your faction signature (even if you are neutral), even moving that entity to another rail with no permission module next to it should not change it.

This seems to be the case, till the sector gets unloaded/loaded again, then it will inherit the faction signature of the entity it is docked to. Even if it was factioned before.

It's not too harmful for allies, but for public server docks it can be frustrating/game breaking.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.1926 (Dev)
Category
Control Block System: Rails/Docking
First occurrence (version)
0.19226
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 2 2015, 7:59 PM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Control Block System: Rails/Docking.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19226.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19242.
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Urgent.
lancake changed the task status from Open to In Queue (Game).Jun 2 2015, 8:47 PM
AndyP changed the task status from In Queue (Game) to Open.
AndyP added a subscriber: AndyP.Jun 2 2015, 9:03 PM
AndyP changed the task status from Open to In Queue (Game).

confirmed

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJun 2 2015, 9:06 PM
Restricted Application removed a project: Starmade. · View Herald TranscriptJun 3 2015, 4:15 PM
schema added a commit: Restricted Diffusion Commit.Jun 3 2015, 7:33 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 3 2015, 7:33 PM
lancake lowered the priority of this task from Urgent to Normal.
lancake changed the task status from Resolved to In Queue (Game).Jun 10 2015, 9:05 PM

same behavior as mentioned in the description (tested out on a station + permission module docks)

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJun 10 2015, 9:05 PM
schema added a commit: Restricted Diffusion Commit.Jun 11 2015, 10:01 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 11 2015, 10:01 PM
SmilingDemon set Task Type to Bug.Jun 12 2015, 4:41 PM
SmilingDemon changed Last tested (version) from 0.19242 to 0.1926 (Dev).
SmilingDemon set OS-Specific to No.
SmilingDemon set Hardware-Specific to No.
SmilingDemon set Video Card Vendor to uncertain.
SmilingDemon closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 12 2015, 4:41 PM
AndyP removed a subscriber: AndyP.Jul 19 2015, 7:46 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 8:54 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
Restricted Application added a project: CBS: Rails. · View Herald TranscriptMar 10 2017, 5:51 PM