Page MenuHomeSchine - Phabricator

Starmade | Game config: ship limit affects station and planet entities
Closed, FinishedPublic

Description

The game config allows you to limit the mass or block count of a ship. This however also affects static entities like stations and planets.

The option should be split into ship limit, station limit and planet limit. I think the check also accounts for docked mass so the main entity is a sum of all it docks + itself. There should also be an option to disable that: <IncludeDockedEntity>false</IncludeDockedEntity> in the limit sections.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19441
Category
Blockconfig
First occurrence (version)
0.19431
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Sep 9 2015, 12:58 PM
lancake shifted this object from the S1 Public space to the S3 Starmade space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Blockconfig.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19431.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19431.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to High.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptSep 9 2015, 12:58 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
psycommando added a comment.EditedSep 9 2015, 8:18 PM

-Confirmed-
Tested this on 0.19431, and the value does indeed affect planets and stations. Or at least, on planets it does shows up the warning about the block count being too high, but its hard to test if the planet's weapons and tools would be disabled..

With a station that exceeds the block count, any weapon or tool computer placed directly on it will refuse to fire, even if adequately supplied with power.
It does not affect docked entities however. Turrets can fire freely using the station's power. And docked turrets/entities block count do not add up to the parent station's block limit.

NOTE:: For the test, the blocks limit was set to 100. Mass limit was left at default.

How to reproduce(Station):

  1. Build a station with 100 blocks, of which are a weapon computer and its module, and a number of power reactors.
  2. Enter the computer, fire, and notice how it works.
  3. Place 1 more blocks, get into computer, fire and notice how it does not work + the warning shows up.

How to reproduce(Planet):

  1. Get on a planet.
  2. Place a build block.
  3. Enter build block.
  4. Notice warning about block count being too high.
psycommando changed the task status from Open to In Queue (Game).Sep 9 2015, 8:22 PM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptSep 9 2015, 8:22 PM
Restricted Application added a commit: Restricted Diffusion Commit.Sep 10 2015, 5:15 AM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptSep 10 2015, 5:15 AM
psycommando added a comment.EditedSep 14 2015, 1:41 AM

Tested on version 0.19434.
Planets and stations are now unaffected by the ship block/mass limit config.
However, the ship mass limit doesn't seem to work.. The block count limit does work however.

I set the block limit to 1000, and the mass limit to 11.0. But the ship wouldn't be disabled after adding enough blocks to go past 12.0+ mass.

(EDIT: Some of the issue's properties got changed for some reasons when I changed the last tested version. I didn't change anything besides last tested version for the record. )

psycommando set Task Type to Bug.Sep 14 2015, 1:42 AM
psycommando changed Last tested (version) from 0.19431 to 0.19434.
psycommando set OS-Specific to No.
psycommando set Hardware-Specific to No.
psycommando set Video Card Vendor to uncertain.
psycommando changed the task status from Resolved to In Queue (Game).Sep 14 2015, 1:55 AM
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptSep 14 2015, 1:55 AM
Restricted Application added a commit: Restricted Diffusion Commit.Sep 14 2015, 3:32 AM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptSep 14 2015, 3:32 AM
psycommando removed psycommando as the assignee of this task.
Restricted Application added a subscriber: Megacrafter127. · View Herald TranscriptSep 26 2015, 10:57 PM
Megacrafter127 changed the task status from Resolved to In Queue (Game).Sep 27 2015, 9:26 AM

-QA Testing-
Fix confirmed.
Entities now only abide by the limits for their own type, if those were set.
However, one of the popups indicating the limit-breach has the mass variable mistaken for the block-count variable. Floating point steps also play a part:

Config contents:

  • Ship
    • Block limit: 1000
    • Mass limit: 5.1
  • Station
  • Planet
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptSep 27 2015, 9:26 AM
Megacrafter127 lowered the priority of this task from High to Trivial.Sep 27 2015, 9:26 AM
Restricted Application added a commit: Restricted Diffusion Commit.Oct 4 2015, 4:57 AM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptOct 4 2015, 4:57 AM

-QA testing-
fix not included in latest dev-build.

Megacrafter127 closed this task as Closed.Oct 17 2015, 4:12 PM

-QA Testing-
Fix confirmed. Behaviour and displayed info match the config.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptOct 17 2015, 4:12 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
Megacrafter127 changed Last tested (version) from 0.19434 to 0.19441.Oct 17 2015, 6:58 PM
Restricted Application added a project: Blockconfig. · View Herald TranscriptMar 10 2017, 6:26 PM