Page MenuHomeSchine - Phabricator
Create Task
Maniphest T510

Starmade | undocking ship from shipyard will usually redock it immediately
Closed, FinishedPublic
Actions

Description

2 issues:

  1. If you press the "undock" button and undock a constructed or a docked ship from a shipyard, you won't be able to re-dock that ship to the same shipyard.
  2. When pressing the "undock" button, you'll always get the error message "no ship docked!" but it undocks fine anyway.

This is what you get:

How to reproduce:

  1. dock a ship to a shipyard/construct a design
  2. undock it by pressing the "undock" button (and notice that you get the error message "no ship docked!")
  3. try to re-dock that ship to the same shipyard
  4. you can't and it will give you the message that it does not fit which is not true.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
V0.19428 (Dev)
Category
Control Block System: Shipyards
First occurrence (version)
0.19368 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Aug 15 2015, 8:37 AM
lancake shifted this object from the S1 Public space to the S3 Starmade space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "All Users".
lancake changed Category from none/unspecified to Control Block System: Rails/Docking.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19368 (Dev).
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19370 (Dev).
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to High.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptAug 15 2015, 8:37 AM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake changed the task status from Open to In Queue (Game).Aug 15 2015, 12:06 PM
lancake claimed this task.
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptAug 15 2015, 12:06 PM
lancake added a comment.Aug 15 2015, 4:58 PM

Partially fixed, this still happens:

When pressing the "undock" button, you'll always get the error message "no ship docked!" but it undocks fine anyway.

lancake set Task Type to Bug.Aug 15 2015, 4:58 PM
lancake changed Last tested (version) from 0.19370 (Dev) to 0.19372 (Dev).
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
schema added a commit: Restricted Diffusion Commit.Aug 16 2015, 10:42 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptAug 16 2015, 10:42 AM
Zackey_TNT moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Aug 19 2015, 6:57 AM
Zackey_TNT added a subscriber: Zackey_TNT.

Fix confirmed! able to undock and redock without any issues using both the core beam and rail docker (Might not be intended to be able to use core beams to dock but going to leave that alone)

Tested on latest dev build (0.19385)

The popup has also been fixed and i do not get "no ship docked" as a warning msg...

Zackey_TNT changed Reproducible from Yes to No.Aug 19 2015, 9:01 AM
Zackey_TNT changed Last tested (version) from 0.19372 (Dev) to 0.19385 (Dev).
Zackey_TNT closed this task as Closed.Aug 19 2015, 9:09 AM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptAug 19 2015, 9:09 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
Zackey_TNT reopened this task as Open.Aug 19 2015, 12:15 PM
Restricted Application added a project: Issue Navigation. · View Herald TranscriptAug 19 2015, 12:15 PM
Zackey_TNT added a comment.EditedAug 19 2015, 12:19 PM

Reopening as undocking with a constructed design that has a rail docker on it still shows the popup

To reproduce:
Create design with rail docker
Make it
Undock it while being in the shipcore and using the rail docker to do so.

Retested in 0.19388 still happening using above steps.

Zackey_TNT changed the task status from Open to In Queue (Game).Aug 19 2015, 12:19 PM
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptAug 19 2015, 12:19 PM
Zackey_TNT changed Last tested (version) from 0.19385 (Dev) to 0.19388 (Dev).Aug 19 2015, 12:27 PM
Zackey_TNT added a comment.Aug 24 2015, 9:02 PM

Retested in 0.19407 Dev Still happening "No ship docked" popup still reproducable however take note this does not mean you are unable to dock far from it just when you undock with a rail docker it will tell you that there isn't a ship docked

Zackey_TNT changed Reproducible from No to Yes.Aug 24 2015, 9:02 PM
Zackey_TNT changed Last tested (version) from 0.19388 (Dev) to 0.19407 (Dev).
schema added a subscriber: schema.Sep 1 2015, 2:05 AM
schema lowered the priority of this task from High to Normal.
schema added a commit: Restricted Diffusion Commit.Sep 1 2015, 2:05 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptSep 1 2015, 2:05 AM
Nightwakler_007 added a subscriber: Nightwakler_007.Sep 2 2015, 1:47 AM

I've seen this happen to. The other problem encountered when undocking a ship is that it can be impossible to activate the core. Instead of activating the core, the anchor is selected (which does nothing, of course). If the anchor block activation area was made smaller than all other blocks, then this would resolve the issue. Or, better still, make the anchor block an inactive/invisible entity unless in flight or build mode.

Zackey_TNT changed the task status from Resolved to In Queue (Game).Sep 6 2015, 8:02 AM

-QA Testing-

Fix failed!

We are now unable to undock using the shipcore

Rail docker is able to undock and the popup is gone in both cases

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptSep 6 2015, 8:02 AM
Zackey_TNT changed Last tested (version) from 0.19407 (Dev) to V0.19428 (Dev).Sep 6 2015, 8:02 AM
lancake added a comment.Sep 11 2015, 9:34 PM

Correction: You are able to undock by using the shipcore, but you have to fire the beam for a very very short duration to do so, else you just trigger the docking signal again.

Possible fix is adding a small delay to the beam after undocking where it can't redock.

TIME added a subscriber: TIME.Sep 12 2015, 8:58 PM

not a fix, but related; In the current release version if you turn the ship yard off then turn it back on it seems to make the ship dockable again when experiencing this problem.

AndyP changed Category from Control Block System: Rails/Docking to Control Block System: Shipyards.Oct 26 2015, 10:29 PM
lancake renamed this task from undocking ship from shipyard will not allow you to redock it to undocking ship from shipyard will usually redock it immediately.Dec 4 2015, 3:45 PM
schema changed the task status from In Queue (Game) to Resolved.Jan 28 2016, 9:02 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJan 28 2016, 9:02 PM
Zackey_TNT closed this task as Closed.Feb 3 2016, 7:46 AM

-QA Testing-

Fix confirmed, unable to reproduce, shipcore is able to undock and redock freely.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptFeb 3 2016, 7:46 AM
Restricted Application added a project: CBS: Shipyards. · View Herald TranscriptMar 10 2017, 6:28 PM