Page MenuHomeSchine - Phabricator

Starmade | Faction Ship Permission issue
Closed, RejectedPublic

Description

You can enter a docked ship regardless of permissions that are set on the main ship that ship is docked to.

The end result is that you are able to enter parts of a ship regardless of its permissions required inside the faction.

So stuff like generators turrets and docked drones can be griefed by rank 4 players. (the lowest rank)

To reproduce:

  1. Make a ship and put a faction module on it
  2. Get another player to join your faction
  3. Set that ship you made to founder required permissions
  4. Dock a ship to the main ship
  5. Have that low rank member enter the dock ship

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
uncertain
Last tested (version)
V0.1932
Category
Control Block System: Functional
First occurrence (version)
V0.1932
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Zackey_TNT updated the task description. (Show Details)Jul 18 2015, 4:47 PM
Zackey_TNT added a project: Starmade.
Zackey_TNT changed Category from none/unspecified to Control Block System: Functional.
Zackey_TNT changed Affected Gamemode(s) from none/unspecified to Single and Multi.
Zackey_TNT set First occurrence (version) to V0.1932.
Zackey_TNT set Last tested (version) to V0.1932.
Zackey_TNT edited Serverconfig (server.cfg). (Show Details)
Zackey_TNT edited Clientconfig (settings.cfg). (Show Details)
Zackey_TNT added a subscriber: Zackey_TNT.
Zackey_TNT created this task.
Zackey_TNT raised the priority of this task from to High.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJul 18 2015, 4:47 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
AndyP changed the visibility from "Custom Policy" to "Custom Policy".Jul 18 2015, 5:36 PM
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP set Task Type to Bug.
AndyP set Reproducible to uncertain.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
AndyP claimed this task.
AndyP removed AndyP as the assignee of this task.
AndyP raised the priority of this task from High to Urgent.

Validated

Custom view policy:
Author + Starmade

Found relations:
T28

AndyP shifted this object from the S1 Public space to the Restricted Space space.Aug 11 2015, 11:32 PM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Starmade (Project)" to "All Users".

not seeing this as a bug

if the docked entities were to inherit the motherships' faction rank requirement then:

  • you wouldn't be able to have lower ranks manning your turrets
  • lower ranks would not be able to enter and launch docked fighters
  • in the case of a station set to founder, lower ranked players would dock but not be able to undock their ship or if rank prevents docking then they would not be able to dock at all (except permission blocks but then anyone could dock there)

if you need to secure turrets or docked entities such as generators,turrets or fighters from lower ranked faction mambers place a faction block on it set to a rank higher than the members you don't want getting in

also the author is not able to see this task since it was set to private

AndyP shifted this object from the Restricted Space space to the S3 Starmade space.Aug 27 2015, 9:02 PM
spunkie closed this task as Rejected.EditedAug 27 2015, 9:45 PM
spunkie claimed this task.

-Rejected-

-not a bug

passive inheritance of faction rank permissions is not intended nor desireable

to protect docked entities from lower ranked faction members the entity requires its own faction block with the desired rank permission

Restricted Application removed a project: Issue Navigation. · View Herald TranscriptAug 27 2015, 9:45 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP removed spunkie as the assignee of this task.Sep 7 2015, 9:05 PM
Restricted Application added a project: CBS: Functional. · View Herald TranscriptMar 10 2017, 6:30 PM