Page MenuHomeSchine - Phabricator

Starmade | Power/Shield Drain and supply beams power issues
Closed, FinishedPublic

Description

Power Drain Beams leave you with less power than you started with, in every configuration EXCEPT Drain + Cannon (including no support computer)

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19439 (Dev)
Category
Engine
First occurrence (version)
0.19228
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain

Event Timeline

SmilingDemon updated the task description. (Show Details)Jul 4 2015, 2:50 PM
SmilingDemon added a project: Starmade.
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon changed Category from none/unspecified to Engine.
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Single and Multi.
SmilingDemon set First occurrence (version) to 0.19228.
SmilingDemon changed Reproducible from uncertain to Yes.
SmilingDemon set Last tested (version) to 0.19306 (Dev).
SmilingDemon edited a custom field.
SmilingDemon edited Serverconfig (server.cfg). (Show Details)
SmilingDemon edited Clientconfig (settings.cfg). (Show Details)
SmilingDemon added a subscriber: SmilingDemon.
SmilingDemon created this task.
SmilingDemon raised the priority of this task from to Normal.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJul 4 2015, 2:50 PM
SmilingDemon changed the task status from Open to In Queue (Game).Jul 4 2015, 2:52 PM

Drain Beam + Cannon gives a constant energy supply to power the Beam

single Drain Beam consumes more power than it supplies (even though it states otherwise in the structure info)

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJul 4 2015, 2:52 PM
AndyP added a subscriber: AndyP.Jul 22 2015, 10:13 PM

This is an intended function to avoid abuse as "power supply reversal"

All beams need a power penalty to not bypass the power calculation curve.
The idea on power drain beams is to keep the power of the target down, and not to leech from the energy.

Thought so too - but it looks like the beam cannon combo is then abusing that by powering itself

schema added a commit: Restricted Diffusion Commit.Jul 25 2015, 2:50 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 25 2015, 2:50 PM
schema added a subscriber: schema.Jul 25 2015, 2:51 PM

Bug was due to inaccuracies in beam power consumption.

All power consumption values have now been changed to be per tick to give an accurate representation on how much power is consumed with how many ticks done

lancake changed the task status from Resolved to In Queue (Game).

Found more power related issues with support tools so I'm going to put it in this task:
Tests below are from standalone computers, they had no support/slave.

Power supply beam:

  • the power consumed is incorrect when you're hitting a target (it's fine if you don't). It's in total the normal base consumption + the power supplied.

So if I have a beam that supplies 480 000 and consumes 600 000. I'll supply 480 000 to my target but consume 480 000 + 600 000 my self.

Power drain beam:

  • in most cases, its power consumption is incredibly high. The first tick seems to be OK as far as I can see, the 4 after that experience increased power usage. In my example it should have consumed 24 000 per tick, but it did 67 754 702 for the remaining 4 ticks. This issue seems to depend on how much power storage or current power your target has but I have yet to find the exact reason. The power use per second number displayed next to your power capacity bar on your HUD is showing the number that it should be.
  • the power drain is lower than it should be, should be 48 000 per tick, but it was 9600. Seems to me that the <DrainPerHit>120</DrainPerHit> is total power drained, and not per tick as you expect from the other weapons/support tools. Could be that the drain per hit is just divided by the amount of ticks in the burst.

Shield drain beam:

  • the power consumed is the similar to the power drain beam issue. My beam should have consumed 120 000 (24 000 per tick) but it only did 24 000 in total, 4800 per tick. The power use per second number displayed next to your power capacity bar on your HUD is showing the number that it should be.

Shield supply beam:

  • appears to be fine, i'm wondering if it's intended that it drains your own shield too? You basically transfer your own shields to another ship, but you have to pay a large power price for it.
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 25 2015, 9:38 PM
AndyP awarded a token.Jul 25 2015, 9:45 PM
schema changed the task status from In Queue (Game) to Resolved.Jul 27 2015, 11:23 PM

added 2 config options for power supply and 2 for power drain because it was adding/subtracting the power taken/given from the giver/taker. shield supply needs the config options checked.

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 27 2015, 11:23 PM
lancake changed the task status from Resolved to In Queue (Game).Jul 28 2015, 9:12 PM

Power supply and drain work fine now. The added config options also do what they are supposed to do. I've also checked out 3 randomly chosen combo weapons, 1 at 100% and 2 at 50%. Correct power usage, drained and supplied.

Shield supply and drain also work but they don't have those added config options. Putting in queue since they need those config options the most.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 28 2015, 9:12 PM
lancake set Task Type to Bug.Jul 28 2015, 9:12 PM
lancake changed Last tested (version) from 0.19306 (Dev) to 0.19348 (Dev).
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake renamed this task from Power Drain Beams use more power than they provide to Power/Shield Drain and supply beams power issues.Aug 1 2015, 8:53 AM
Megacrafter127 shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:55 PM
Megacrafter127 changed the edit policy from "Starmade (Project)" to "All Users".
Megacrafter127 edited Serverconfig (server.cfg). (Show Details)
Megacrafter127 edited Clientconfig (settings.cfg). (Show Details)
Megacrafter127 added a subscriber: Megacrafter127.
Megacrafter127 claimed this task.
Megacrafter127 removed Megacrafter127 as the assignee of this task.

respacing

mclaih added a subscriber: mclaih.Sep 9 2015, 2:58 AM
lancake closed this task as Closed.Sep 26 2015, 9:06 AM

-QA Testing-

Fix confirmed: those config options got added at some point, checked it out now and also reconfirmed the previous fixes. Everything mentioned in here works like it should now.

Restricted Application removed a project: Game Development. · View Herald TranscriptSep 26 2015, 9:06 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.19348 (Dev) to 0.19349 (Dev).Sep 26 2015, 9:06 AM
lancake changed Last tested (version) from 0.19349 (Dev) to 0.19439 (Dev).Sep 26 2015, 10:09 AM
Croquelune added a comment.EditedJul 2 2016, 5:22 PM

v 0.198.223#20160627_191803

I just tried 1 Shield Drain + 1 Beam (so 100% efficiency)

It said 60 drain
0.5 ticks
600 energy

But actually it does only 30 drain per tick, reach 1200e/s power consumption on the HUD and often miss 1 tick so does 4 hits instead 5. Result = 120~150 shield drained instead of 300.

Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:31 PM