Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2971

Starmade | Explosions and Acid damage conflict and results in nullpointers
Closed, FinishedPublic
Actions

Description

When firing b/b into the front of a target ship (1.0 power version of ship I'm working on) the game will process the first few ticks and then freeze. Process remains active after closing the game, requiring task manager to close. Ships are available for testing in this download: http://www.mediafire.com/file/atfnaezffe5h3e4/SkubTest.zip

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.201.06x
Category
Control Block System: Weapons
First occurrence (version)
0.201.003
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Apply large amounts of acid damage to your target
  2. Make sure the target has systems with integrity, so that cause integrity explosions
  3. OR Apply a lot of missile and acid damage at the same time to your target

should eventually run into a point where damage refuses to apply.

Tester information (Internal use only)

-validated- & -confirmed-

Acid damage and explosion damage doesn't like to co-exist on the same blocks. Easy enough to encounter by using a high damage acid weapon such as a death beam (up the damage in the config if needed) and shooting at a target with systems to cause integrity explosions.

[2018-04-22 22:44:34] Exception: tried to remove controller: Explosive Effect Module(421): ModuleMap [all=(ActivationElementManager: TYPE_ALL), signal=(ActivationElementManager: TYPE_ALL), railTrack=(RailSpeedElementManager: TYPE_RAIL_TRACK)] for Ship[Striker Class_1524429851490](220)
[2018-04-22 22:44:34] Exception: tried to remove controller: Explosive Effect Module(421): ModuleMap [all=(ActivationElementManager: TYPE_ALL), signal=(ActivationElementManager: TYPE_ALL), railTrack=(RailSpeedElementManager: TYPE_RAIL_TRACK)] for Ship[Striker Class_1524429851490](220)
[2018-04-22 22:44:34] [SERVER][UPDATE] WARNING: object local update of Ship[Striker Class_1524429851490](220) took 64
[2018-04-22 22:44:34] [SERVER][UPDATE] WARNING: object local update of 14 objects took 66
[2018-04-22 22:44:34] [ControlElementMap] RemoveControlBlock: REMOVED CACHE: 154619871249 ---> null; {}
[2018-04-22 22:44:34] [ControlElementMap] RemoveControlBlock: REMOVED CACHE: 167504838672 ---> null; {}
[2018-04-22 22:44:34] [ControlElementMap] RemoveControlBlock: REMOVED CACHE: 167504773137 ---> null; {}
[2018-04-22 22:44:34] Exception in thread "pool-2-thread-29" 
[2018-04-22 22:44:34] java.lang.NullPointerException: Exception: REQUESTED TYPE 0 IS NULL
[2018-04-22 22:44:34] 	at org.schema.game.common.data.element.ElementKeyMap.getInfo(ElementKeyMap.java:788)
[2018-04-22 22:44:34] 	at org.schema.game.common.data.element.ElementKeyMap.convertToFullHP(ElementKeyMap.java:1803)
[2018-04-22 22:44:34] 	at org.schema.game.common.data.explosion.ExplosionCubeConvexBlockCallback.update(ExplosionCubeConvexBlockCallback.java:64)
[2018-04-22 22:44:34] 	at org.schema.game.common.data.explosion.ExplosionCollisionSegmentCallback.updateCallbacks(ExplosionCollisionSegmentCallback.java:119)
[2018-04-22 22:44:34] 	at org.schema.game.common.data.explosion.ExplosionRunnable.run(ExplosionRunnable.java:295)
[2018-04-22 22:44:34] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[2018-04-22 22:44:34] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[2018-04-22 22:44:34] 	at java.lang.Thread.run(Thread.java:745)

full logs:

logstarmade.1.log1 MBDownload

Serverconfig (server.cfg)
 <replace this block with the file content, 
but do not remove the first and last line. 
Before using the paste function, mark the area from the 
opening angle bracket to the closing angle bracket>
Clientconfig (settings.cfg)
 <replace this block with the file content, 
but do not remove the first and last line. 
Before using the paste function, mark the area from the 
opening angle bracket to the closing angle bracket>

Related Objects

Event Timeline

Comr4de created this task.Apr 22 2018, 5:38 AM
lancake moved this task from New / Unconfirmed to Confirmed on the Issue Navigation board.Apr 22 2018, 8:59 PM
lancake added a subscriber: lancake.
lancake claimed this task.

-validated- & -confirmed-

Acid damage and explosion damage doesn't like to co-exist on the same blocks. Easy enough to encounter by using a high damage acid weapon such as a death beam (up the damage in the config if needed) and shooting at a target with systems to cause integrity explosions.

[2018-04-22 22:44:34] Exception: tried to remove controller: Explosive Effect Module(421): ModuleMap [all=(ActivationElementManager: TYPE_ALL), signal=(ActivationElementManager: TYPE_ALL), railTrack=(RailSpeedElementManager: TYPE_RAIL_TRACK)] for Ship[Striker Class_1524429851490](220)
[2018-04-22 22:44:34] Exception: tried to remove controller: Explosive Effect Module(421): ModuleMap [all=(ActivationElementManager: TYPE_ALL), signal=(ActivationElementManager: TYPE_ALL), railTrack=(RailSpeedElementManager: TYPE_RAIL_TRACK)] for Ship[Striker Class_1524429851490](220)
[2018-04-22 22:44:34] [SERVER][UPDATE] WARNING: object local update of Ship[Striker Class_1524429851490](220) took 64
[2018-04-22 22:44:34] [SERVER][UPDATE] WARNING: object local update of 14 objects took 66
[2018-04-22 22:44:34] [ControlElementMap] RemoveControlBlock: REMOVED CACHE: 154619871249 ---> null; {}
[2018-04-22 22:44:34] [ControlElementMap] RemoveControlBlock: REMOVED CACHE: 167504838672 ---> null; {}
[2018-04-22 22:44:34] [ControlElementMap] RemoveControlBlock: REMOVED CACHE: 167504773137 ---> null; {}
[2018-04-22 22:44:34] Exception in thread "pool-2-thread-29" 
[2018-04-22 22:44:34] java.lang.NullPointerException: Exception: REQUESTED TYPE 0 IS NULL
[2018-04-22 22:44:34] 	at org.schema.game.common.data.element.ElementKeyMap.getInfo(ElementKeyMap.java:788)
[2018-04-22 22:44:34] 	at org.schema.game.common.data.element.ElementKeyMap.convertToFullHP(ElementKeyMap.java:1803)
[2018-04-22 22:44:34] 	at org.schema.game.common.data.explosion.ExplosionCubeConvexBlockCallback.update(ExplosionCubeConvexBlockCallback.java:64)
[2018-04-22 22:44:34] 	at org.schema.game.common.data.explosion.ExplosionCollisionSegmentCallback.updateCallbacks(ExplosionCollisionSegmentCallback.java:119)
[2018-04-22 22:44:34] 	at org.schema.game.common.data.explosion.ExplosionRunnable.run(ExplosionRunnable.java:295)
[2018-04-22 22:44:34] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[2018-04-22 22:44:34] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[2018-04-22 22:44:34] 	at java.lang.Thread.run(Thread.java:745)

full logs:

logstarmade.1.log1 MBDownload

lancake shifted this object from the S1 Public space to the S3 Starmade space.Apr 22 2018, 9:01 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake edited Steps to reproduce. (Show Details)
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed Reproducible from uncertain to Yes.
lancake changed Last tested (version) from 201.003 to 0.201.003.
lancake changed Category from none/unspecified to Control Block System: Weapons.
lancake changed First occurrence (version) from 201.003 to 0.201.003.
lancake raised the priority of this task from Normal to Pre-Release Quality Assurance.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptApr 22 2018, 9:01 PM
lancake renamed this task from Game Freezing while processing damage. to Explosions and Acid damage conflict and results in nullpointers.Apr 22 2018, 9:02 PM
lancake changed the task status from Open to In Queue.
Restricted Application edited projects, added Game Development, CBS: Weapons; removed Issue Navigation. · View Herald TranscriptApr 22 2018, 9:02 PM
schema changed the task status from In Queue to Resolved.Apr 26 2018, 9:23 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 26 2018, 9:23 PM
Comr4de added a comment.May 4 2018, 7:21 AM

I'm still getting crashes from weapons fire but I'm not sure if it's related. Logs attached.

skublogs.zip996 KBDownload

lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Jun 28 2018, 6:33 PM
lancake closed this task as Closed.

-QA Testing-

Original issue and the one in the above logs were fixed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 28 2018, 6:33 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.201.003 to 0.201.06x.Jun 28 2018, 6:33 PM