Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1110

Starmade | "View Relations" does not display correct relationship values
Closed, FinishedPublic
Actions

Description

It displays "OWN" status for the checking faction, not the faction, relations of which are being displayed. It display "FRIEND" status for the faction in question.

http://i.imgur.com/n4R44T2.png - my faction is "Imaginary Numbers", my enemy is "SM1 Scavengers"
http://i.imgur.com/Uz0qy36.png - I am checking "SM1 Scavengers" faction

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19602 (Dev)
Category
Engine
First occurrence (version)
0.19556
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Have a faction yourself
  2. Look at someone else's faction
  3. Check your faction in their list and their own faction
Tester information (Internal use only)

The issue is a small inconsistency or mix-up:

  • Your faction appears as "Own" when looking at another faction's relations.
  • That faction appears as "Friend" when looking at its faction's relations.

Your own faction should just appear as any other faction when looking at someone else's faction relation. Which is "Enemy", "Neutral" or "Friend"
The faction itself you're looking at should appear as "Own".

Event Timeline

EditorRUS updated the task description. (Show Details)Jan 31 2016, 5:12 AM
EditorRUS changed Category from none/unspecified to Engine.
EditorRUS set First occurrence (version) to v0.19556.
EditorRUS edited Serverconfig (server.cfg). (Show Details)
EditorRUS edited Clientconfig (settings.cfg). (Show Details)
EditorRUS changed Reproducible from uncertain to Yes.
EditorRUS edited Steps to reproduce. (Show Details)
EditorRUS added a subscriber: EditorRUS.
EditorRUS created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJan 31 2016, 5:12 AM
EditorRUS updated the task description. (Show Details)Jan 31 2016, 5:17 AM
EditorRUS set Task Type to Bug.
EditorRUS set OS-Specific to No.
EditorRUS set Hardware-Specific to No.
EditorRUS set Video Card Vendor to uncertain.
EditorRUS set Affected Gamemode(s) to none/unspecified.
EditorRUS renamed this task from View relations not working right to "View Relations" does not display correct values.Jan 31 2016, 5:25 AM
lancake added a subscriber: lancake.Jan 31 2016, 1:04 PM
lancake claimed this task.

-Feedback-

Hm, I see. This is a small inconsistency then. It shows "Own" in red because your faction is an enemy to the one you're looking at, that's intended and seems logical to me.

The "Friend" part should in this case be "Own" in light blue.

Do you agree or do you had something else in mind?

lancake shifted this object from the S1 Public space to the S3 Starmade space.Jan 31 2016, 1:05 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed First occurrence (version) from v0.19556 to 0.19556.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set Last tested (version) to 0.19556.
lancake moved this task from New / Unconfirmed to Feedback on the Issue Navigation board.
lancake triaged this task as Trivial priority.
EditorRUS added a comment.Jan 31 2016, 8:58 PM

Yeah, that's right. I haven't found any other problem with this yet.

lancake moved this task from Feedback to Open / Validated on the Issue Navigation board.Feb 1 2016, 1:33 PM
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake added a comment.Feb 1 2016, 1:36 PM

-Confirmed-

Putting in queue then.

The issue is a small inconsistency or mix-up:

  • Your faction appears as "Own" when looking at another faction's relations.
  • That faction appears as "Friend" when looking at its faction's relations.

Your own faction should just appear as any other faction when looking at someone else's faction relation. Which is "Enemy", "Neutral" or "Friend"
The faction itself you're looking at should appear as "Own".

lancake edited Steps to reproduce. (Show Details)Feb 1 2016, 1:39 PM
lancake edited Tester information (Internal use only). (Show Details)
lancake renamed this task from "View Relations" does not display correct values to "View Relations" does not display correct relationship values.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptFeb 1 2016, 1:39 PM
schema added a subscriber: schema.Mar 9 2016, 4:05 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 9 2016, 4:05 PM
lancake added a comment.Mar 10 2016, 6:07 PM

-QA Testing-

Fix confirmed.

lancake changed Last tested (version) from 0.19556 to 0.19602 (Dev).Mar 10 2016, 6:07 PM
lancake closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptMar 10 2016, 6:07 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:18 PM